fix: correct ISO 8601 serialization for negative pendulum Duration values - #377
Merged
Merged
Conversation
…lues The to_iso8601_string() method produced invalid ISO 8601 output for negative durations (e.g., '-P-10D' instead of '-P10D'). This happened because individual component values (days, seconds, etc.) were negative while also being prefixed with '-'. Fixed by taking absolute values of components when the duration is negative. Fixes pydantic#329
yezz123
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Duration.to_iso8601_string()method produces invalid ISO 8601 output for negative durations. For example:The root cause is that individual component values (days, seconds, etc.) are negative, and the code also adds a
-prefix, resulting in double negation in the output string.This also causes data loss during
model_copy(deep=True)since Pydantic serializes viato_iso8601_string()and the invalid string can't be properly deserialized.Fixes #329
Fix
When the duration is negative, take absolute values of all components so the
-prefix alone conveys the sign. The output is now valid ISO 8601:Tests
Added 9 new tests covering:
All 13517 tests pass (up from 13508).