Skip to content

isolate url in Currency - #235

Merged
yezz123 merged 2 commits into
pydantic:mainfrom
edasubert:patch-1
Nov 10, 2024
Merged

yezz123 merged 2 commits into
pydantic:mainfrom
edasubert:patch-1

Conversation

@edasubert

Copy link
Copy Markdown
Contributor

My shell added the dot to the url and brought me to a non existing wikipedia page. Adding a space after the url prevents that from happening

My shell added the dot to the url and brought me to a non existing wikipedia page. Adding a space after the url prevents that from happening
@codecov

codecov Bot commented Nov 10, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e186814) to head (122f0ec).
Report is 52 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #235    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           11        19     +8     
  Lines          685      1047   +362     
  Branches       169       253    +84     
==========================================
+ Hits           685      1047   +362     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yezz123 yezz123 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@yezz123
yezz123 merged commit f27a132 into pydantic:main Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants