Skip to content

Allow python-ulid 3.0 - #222

Merged
yezz123 merged 1 commit into
pydantic:mainfrom
musicinmybrain:python-ulid-3
Oct 12, 2024
Merged

yezz123 merged 1 commit into
pydantic:mainfrom
musicinmybrain:python-ulid-3

Conversation

@musicinmybrain

Copy link
Copy Markdown
Contributor

The API change in this major release is that a TypeError is raised instead of a ValueError if a constructor is called with the wrong type. I don’t think this requires any code changes in pydantic-extra-types, but it’s worth double-checking.

https://github.com/mdomke/python-ulid/releases/tag/3.0.0

Tested with:

$ python3.12 -m venv _e
$ . _e/bin/activate
(_e) $ pip install -e .[all]
(_e) $ pip install -r requirements/testing.in
(_e) $ python -m pytest

The API change in this major release is that a `TypeError` is raised
instead of a `ValueError` if a constructor is called with the wrong
type.

https://github.com/mdomke/python-ulid/releases/tag/3.0.0
@codecov

codecov Bot commented Oct 11, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e186814) to head (e841a48).
Report is 47 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #222    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           11        19     +8     
  Lines          685      1047   +362     
  Branches       169       253    +84     
==========================================
+ Hits           685      1047   +362     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yezz123
yezz123 merged commit 927dcd1 into pydantic:main Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants