Skip to content

Domain name string type - #212

Merged
yezz123 merged 9 commits into
pydantic:mainfrom
matter1-git:type/DomainStr
Sep 6, 2024
Merged

yezz123 merged 9 commits into
pydantic:mainfrom
matter1-git:type/DomainStr

Conversation

@matter1-git

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Sep 6, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e186814) to head (816dcc4).
Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #212    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           11        19     +8     
  Lines          685      1047   +362     
  Branches       169       253    +84     
==========================================
+ Hits           685      1047   +362     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yezz123 yezz123 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @matter1-git Thanks for your work, i left some comments for you, I'm happy to discuss anything around this.

also can you add to test_json_schema.py this code:

        (
            DomainStr,
            {
                'title': 'Model',
                'type': 'object',
                'properties': {
                    'x': {
                        'title': 'X',
                        'type': 'string',
                    },
                },
                'required': [
                    'x',
                ],
            },
        ),

Comment thread pydantic_extra_types/domain.py
Comment thread tests/test_domain.py
@matter1-git

Copy link
Copy Markdown
Contributor Author

I have added the suggested changes and test cases. 🚀

Comment thread pydantic_extra_types/domain.py Outdated

@yezz123 yezz123 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants