Add SemanticVersion type - #195
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
yezz123
approved these changes
Jul 2, 2024
yezz123
left a comment
Collaborator
There was a problem hiding this comment.
LGTM 🚀 Thanks @nikstuckenbrock
Contributor
Author
|
Thanks for fixing the requirements for me, I was having lunch 😁 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there,
I've found this discussion while searching for a common
SemanticVersiontype. I know from the discussion when to add a new type that there should be at least 30 upvotes which is not the case by now. However, I am sure that this type would be a useful addition, as it is already recommended by the semver package itself: https://python-semver.readthedocs.io/en/latest/advanced/combine-pydantic-and-semver.html.Let me know what you think. :)