Skip to content

Add timezone name validation - #193

Merged
yezz123 merged 4 commits into
pydantic:mainfrom
07pepa:add-timezone-name-validation
Jul 3, 2024
Merged

yezz123 merged 4 commits into
pydantic:mainfrom
07pepa:add-timezone-name-validation

Conversation

@07pepa

@07pepa 07pepa commented Jun 30, 2024

Copy link
Copy Markdown
Contributor

closes #191

@07pepa
07pepa force-pushed the add-timezone-name-validation branch 5 times, most recently from bf5561d to aa6e831 Compare June 30, 2024 16:43
@codecov

codecov Bot commented Jun 30, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@07pepa
07pepa force-pushed the add-timezone-name-validation branch 9 times, most recently from ffe7de5 to 68dfef1 Compare June 30, 2024 16:58
@07pepa

07pepa commented Jun 30, 2024

Copy link
Copy Markdown
Contributor Author

@yezz123 ready to merge

as usual use existing library to get exhaustive set and use it for validation
this time with strict mode again

Comment thread pydantic_extra_types/timezone_name.py Outdated
Comment thread pydantic_extra_types/timezone_name.py Outdated
Comment thread pydantic_extra_types/timezone_name.py Outdated
Comment thread pyproject.toml Outdated
Comment thread pydantic_extra_types/timezone_name.py
Comment thread Makefile Outdated
@07pepa
07pepa force-pushed the add-timezone-name-validation branch 8 times, most recently from ebfda09 to 5fa0887 Compare July 3, 2024 07:58
@07pepa
07pepa force-pushed the add-timezone-name-validation branch from 5fa0887 to a485e86 Compare July 3, 2024 07:59
@07pepa

07pepa commented Jul 3, 2024

Copy link
Copy Markdown
Contributor Author

@yezz123 If you look there is lot of # pragma: no cover because different versions of python maybe start using something like this

@07pepa

07pepa commented Jul 3, 2024

Copy link
Copy Markdown
Contributor Author

@yezz123 ready to review / merge

@yezz123 yezz123 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @07pepa for the amazing work, i updated some stuff regarding the code including TypeHint & Also adding a wrapper for strict mode

@yezz123 yezz123 changed the title add timezone name validation Add timezone name validation Jul 3, 2024
@yezz123
yezz123 merged commit c55eea7 into pydantic:main Jul 3, 2024
@07pepa
07pepa deleted the add-timezone-name-validation branch August 24, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add field for IANA timezone names

2 participants