Do not pin the ”major” version of pycountry - #132
Merged
Merged
Conversation
Since pycountry uses a calendar-based versioning scheme, this doesn’t have the effect it would for a SemVer dependency. Breaking changes are not more likely to happen at the beginning of a calendar year than in the middle of one, and pinning the version is likely to cause more headaches than it prevents.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 685 685
Branches 169 169
=========================================
Hits 685 685 ☔ View full report in Codecov by Sentry. |
Kludex
approved these changes
Jan 31, 2024
Member
|
Thanks @musicinmybrain 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since pycountry uses a calendar-based versioning scheme, this doesn’t have the effect it would for a SemVer dependency. Breaking changes are not more likely to happen at the beginning of a calendar year than in the middle of one, and pinning the version is likely to cause more headaches than it prevents.