buffer: add isByteString - #66298
Open
jasnell wants to merge 1 commit into
Open
buffer: add isByteString#66298jasnell wants to merge 1 commit into
jasnell wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
Contributor
|
I don't think |
Member
Author
|
Yeah, I'm going to rename to |
7 tasks
jasnell
force-pushed
the
jasnell/islatin1
branch
from
September 25, 2026 19:13
5826c3c to
98b8ffc
Compare
Renegade334
reviewed
Sep 25, 2026
jasnell
force-pushed
the
jasnell/islatin1
branch
from
September 25, 2026 19:37
98b8ffc to
07f71ca
Compare
Renegade334
approved these changes
Sep 25, 2026
Implements a fast check to determine if a string is a valid byte string (only chars <= 0xff). Can be up to 58x faster than the equivalent regex check. Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
jasnell/islatin1
branch
from
September 25, 2026 19:41
07f71ca to
090b087
Compare
Collaborator
panva
approved these changes
Sep 25, 2026
Renegade334
approved these changes
Sep 25, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66298 +/- ##
==========================================
+ Coverage 90.36% 90.37% +0.01%
==========================================
Files 790 790
Lines 273842 273876 +34
Branches 52386 52393 +7
==========================================
+ Hits 247453 247523 +70
+ Misses 16881 16852 -29
+ Partials 9508 9501 -7
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a fast check to determine if a string is
Latin1a byte string.Can be many times faster than the equivalent regex check.
(the larger perf gap there is with concatenated strings)