Skip to content

stream: port remaining SonicBoom tests for Utf8Stream - #66275

Open
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:fix/fast-utf8-stream-max-write-retries
Open

mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:fix/fast-utf8-stream-max-write-retries

Conversation

@mcollina

Copy link
Copy Markdown
Member

Port the SonicBoom tests that could not be imported directly because they depend on the third-party proxyquire module, along with the maxWriteRetries option they exercise, into the Utf8Stream module.

Adds maxWriteRetries support, which bounds consecutive EAGAIN/EBUSY retry attempts and resets the counter on forward progress, plus drop-event and flush-callback edge-case coverage.

Fixes: #58955


AI generated, reviewed by me

Port the SonicBoom tests that could not be imported directly because they
depend on the third-party proxyquire module, along with the maxWriteRetries
option they exercise, into the Utf8Stream module.

Adds maxWriteRetries support, which bounds consecutive EAGAIN/EBUSY retry
attempts and resets the counter on forward progress, plus drop-event and
flush-callback edge-case coverage.

Fixes: nodejs#58955

Assisted-by: pi
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@mcollina
mcollina requested a review from jasnell September 25, 2026 08:34
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to Node.js streams. labels Sep 25, 2026
@mcollina
mcollina force-pushed the fix/fast-utf8-stream-max-write-retries branch from f803775 to 919e61f Compare September 25, 2026 08:34
@codecov

codecov Bot commented Sep 25, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.41935% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.35%. Comparing base (ebef774) to head (919e61f).
⚠️ Report is 112 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/streams/fast-utf8-stream.js 77.41% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #66275      +/-   ##
==========================================
+ Coverage   90.28%   90.35%   +0.06%     
==========================================
  Files         790      789       -1     
  Lines      271642   273521    +1879     
  Branches    51846    52289     +443     
==========================================
+ Hits       245260   247142    +1882     
+ Misses      16889    16837      -52     
- Partials     9493     9542      +49     
Files with missing lines Coverage Δ
lib/internal/streams/fast-utf8-stream.js 82.59% <77.41%> (+1.72%) ⬆️

... and 96 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. stream Issues and PRs related to Node.js streams.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking Issue: Port all SonicBoom tests for FastUtf8Stream

2 participants