Add n_e_right_bc to EdgeModelOutputs and implement _update_density. - #2498
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
Complete the base core boundary condition interface by adding electron density (n_e_right_bc) to EdgeModelOutputs. In ExtendedLengyelOutputs, default n_e_right_bc to jnp.nan as Lengyel does not predict core density. Implement _update_density in torax/_src/edge/updaters.py to update runtime_params.profile_conditions.n_e_right_bc, and add unit test coverage in edge_updaters_test.py. PiperOrigin-RevId: 983998350
copybara-service
Bot
force-pushed
the
test_983998350
branch
from
September 25, 2026 14:15
17157fa to
f1d109e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add n_e_right_bc to EdgeModelOutputs and implement _update_density.
Complete the base core boundary condition interface by adding electron density (n_e_right_bc) to EdgeModelOutputs.
In ExtendedLengyelOutputs, default n_e_right_bc to jnp.nan as Lengyel does not predict core density.
Implement _update_density in torax/_src/edge/updaters.py to update runtime_params.profile_conditions.n_e_right_bc, and add unit test coverage in edge_updaters_test.py.