Remove duplicate pedestal_transport_models workaround in test_iterhybrid_lh_transition. - #2495
Open
copybara-service[bot] wants to merge 1 commit into
Open
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
…hybrid_lh_transition`. Now that `TurbulentTransport` separates `core` and `pedestal` contributions and `ADAPTIVE_TRANSPORT` scales `core_transport.turbulent.core` while preserving `core` contributions in the pedestal region when `pedestal_transport_models` is empty, `test_iterhybrid_lh_transition.py` no longer needs a duplicate `prescribed` entry under `pedestal_transport_models`. - Remove `pedestal_transport_models` (`TODO(browntheodore)`) from `test_iterhybrid_lh_transition.py` and regenerate `test_iterhybrid_lh_transition.nc`. - Remove the corresponding `del CONFIG[transport][pedestal_transport_models]` workaround from `test_iterhybrid_lh_transition_internal_boundary_condition.py`. PiperOrigin-RevId: 985214452
copybara-service
Bot
force-pushed
the
test_985214452
branch
from
September 24, 2026 21:28
e170a2a to
80a43a6
Compare
pedestal_transport_models workaround in test_iterhybrid_lh_transition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove duplicate
pedestal_transport_modelsworkaround intest_iterhybrid_lh_transition.Now that
TurbulentTransportseparatescoreandpedestalcontributions andADAPTIVE_TRANSPORTscalescore_transport.turbulent.corewhile preservingcorecontributions in the pedestal region whenpedestal_transport_modelsis empty,test_iterhybrid_lh_transition.pyno longer needs a duplicateprescribedentry underpedestal_transport_models.pedestal_transport_models(TODO(browntheodore)) fromtest_iterhybrid_lh_transition.pyand regeneratetest_iterhybrid_lh_transition.nc.del CONFIG[transport][pedestal_transport_models]workaround fromtest_iterhybrid_lh_transition_internal_boundary_condition.py.