Deduplicate ExtendedLengyelOutputs construction and refine SOL state types. - #2468
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_982388152
branch
2 times, most recently
from
September 18, 2026 15:52
69b984a to
40bcc2d
Compare
…types. Both `_process_single_guess` and `_run_single_solver` duplicated post-processing and construction of `ExtendedLengyelOutputs`. Additionally, `ExtendedLengyelState` and `DivertorSOL1D.seed_impurity_concentrations` used scalar float types that caused type mismatches with `ExtendedLengyelOutputs`, requiring `# pyrefly: ignore[bad-argument-type]` suppressions. Extract a helper `_build_extended_lengyel_outputs` in `extended_lengyel_standalone.py` to share post-processing and output creation across solvers. Update `ExtendedLengyelState` fields and `DivertorSOL1D.seed_impurity_concentrations` to `jax.Array` for consistent typing. PiperOrigin-RevId: 983894694
copybara-service
Bot
force-pushed
the
test_982388152
branch
from
September 18, 2026 16:06
40bcc2d to
642192f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deduplicate ExtendedLengyelOutputs construction and refine SOL state types.
Both
_process_single_guessand_run_single_solverduplicated post-processing and construction ofExtendedLengyelOutputs. Additionally,ExtendedLengyelStateandDivertorSOL1D.seed_impurity_concentrationsused scalar float types that caused type mismatches withExtendedLengyelOutputs, requiring# pyrefly: ignore[bad-argument-type]suppressions.Extract a helper
_build_extended_lengyel_outputsinextended_lengyel_standalone.pyto share post-processing and output creation across solvers. UpdateExtendedLengyelStatefields andDivertorSOL1D.seed_impurity_concentrationstojax.Arrayfor consistent typing.