Skip to content

Suggest 1s Postgres service healthcheck interval #43243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bensheldon wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Suggest 1s Postgres service healthcheck interval #43243

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0e46c9
Suggest 1s Postgres service healthcheck interval
bensheldon Mar 5, 2026
d9211cc
Don't change health-timeout
bensheldon Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Don't change health-timeout
  • Loading branch information
@bensheldon
bensheldon authored Mar 6, 2026
commit d9211cc8090316069804257072873edb52382d1a
8 changes: 4 additions & 4 deletions ...ns/tutorials/use-containerized-services/create-postgresql-service-containers.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
options: >-
--health-cmd pg_isready
--health-interval 1s
--health-timeout 1s
--health-timeout 5s
--health-retries 30
Comment on lines +67 to +69

Copilot AI Mar 5, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change only updates the PostgreSQL healthcheck values in this file, but there are other PostgreSQL service container examples in the docs that still use the old --health-interval 10s --health-timeout 5s --health-retries 5 values:

  • content/actions/reference/workflows-and-actions/contexts.md (line 417)
  • content/actions/tutorials/migrate-to-github-actions/manual-migrations/migrate-from-circleci.md (lines 242 and 391)

For consistency, those examples should ideally be updated in this PR as well, so readers don't encounter conflicting recommendations depending on which page they land on.

Suggested change
--health-interval 1s
--health-timeout 1s
--health-retries 30
--health-interval 10s
--health-timeout 5s
--health-retries 5

Copilot uses AI. Check for mistakes.

steps:
Expand Down Expand Up @@ -118,7 +118,7 @@ jobs:
options: >-
--health-cmd pg_isready
--health-interval 1s
--health-timeout 1s
--health-timeout 5s
--health-retries 30
```

Expand Down Expand Up @@ -183,7 +183,7 @@ jobs:
options: >-
--health-cmd pg_isready
--health-interval 1s
--health-timeout 1s
--health-timeout 5s
--health-retries 30
ports:
# Maps tcp port 5432 on service container to the host
Expand Down Expand Up @@ -240,7 +240,7 @@ jobs:
options: >-
--health-cmd pg_isready
--health-interval 1s
--health-timeout 1s
--health-timeout 5s
--health-retries 30
ports:
# Maps tcp port 5432 on service container to the host
Expand Down
Loading