Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the incremental topic attribute
retain.progress.after.unsubscribeto preserve a consumer group's committed progress and the WAL files required to resume from that progress after the group unsubscribes from a topic.Configuration and validation
false, preserving the existing unsubscribe behavior.trueorfalse, also case-insensitively.truetofalseremoves retained state for groups that are no longer subscribed. The existingretention.bytesandretention.msattributes remain immutable after topic creation.Progress and WAL lifecycle
Tests
TopicConfigTest: 9 testsCommitProgressKeeperTest: 14 testsSubscriptionQueueRegistryTest: 4 testsmvn test-compile -DskipTests: 53-module reactor,BUILD SUCCESSmvn test-compile -DskipTests -P with-zh-locale: 53-module reactor,BUILD SUCCESSThis PR has:
Key changed/added classes (or packages if there are too many classes) in this PR
TopicConfigandTopicConstant: expose the new topic attribute and its default.SubscriptionInfoandCommitProgressKeeper: validate the attribute and retain or clean ConfigNode progress.ConsensusSubscriptionSetupHandlerandConsensusSubscriptionWalRetention: switch between active queues and detached WAL retention, including recovery and rollback.IoTConsensusServerImplandSubscriptionQueueRegistry: manage WAL retention policies and their atomic lifecycle.