cherry-pick #9346 to v1.83.x and update x/net dependency - #9369
Merged
Merged
Conversation
… tests (grpc#9346) Tests in `stats/opentelemetry` and `stats/opentelemetry/csm` asserted a hardcoded compressed message size of `57` bytes for a 10,000-byte zero payload with gzip compression. In Go 1.27, standard library `compress/gzip` compression improvements changed the output size of this payload from 57 bytes to 54 bytes, causing metric and trace size assertions to fail when executed under newer Go toolchains. Added `GzipCompressedMessageSize` helper in to compute the expected compressed byte length dynamically via `compress/gzip`. Updated metric and trace assertions to use the same. RELEASE NOTES: None
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.83.x #9369 +/- ##
===========================================
+ Coverage 83.32% 87.50% +4.17%
===========================================
Files 421 421
Lines 34119 29278 -4841
===========================================
- Hits 28431 25620 -2811
+ Misses 4261 3658 -603
+ Partials 1427 0 -1427
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR : #9346
Also updates the x/net dependency to ensure compatibility with go1.27 because of the issue reported here : golang/go#80482
RELEASE NOTES: None